Hey guys, it’s been a long time. I was sick for awhile, so sick I have 2 hospital visits which almost landed me 6ft under. This is why I’ve basically been entirely absent the past few months. This has left Burger all alone to do both the public facing PR type stuff (which used to be my territory) and the backend.
Well, my situation is returning to normal, and thus I am also returning to Burggit. I’d like for you to voice your feedback and what you would like to change and any issues you have specifically.
Something I will be changing is, and I hate to be this guy who comes in and does this. I will be removing the 3Dloli community as I personally believe that community violates our at-a-glance policy. I can not tell the difference for most of these images “at a glance” and since I will be the one looking through these sorts of things for moderation. It’s best for everyone involved that I am able to make good accurate decisions.
I also know that there’s been issues with the Lemmy-NSFW fork being used, some people want us to fork it, make modifications to it and use that. I’m going to shoot this idea down now. Burggit is just me and Burger, there’s no one else here, and we do have other things we like working on. We’re not maintaining an entire special fork. It’s likely that we will just go back to the main Lemmy branch, though I would be open to arguments against that or maybe even suggestions for already existing forks to use.
However, I think The Entire Circus made a good point in this post and personally, I agree with his points.
Anyway this is just kind of an initial post letting you know that I am returning and things will be changing. Hopefully this will be overall a good thing for everyone involved. Happy to be back.
Got the reverse proxy banner replacement working:
I do not wish to maintain a git fork of the software. If someone else wants to take on that mantle, they’re more than welcome. I already have enough on my plate. I’m already maintaining the Matrix, Kbin, and this very instance. The few times I used git, I found it frustrating to use.
Thanks for taking the time to wrangle and update it, I think your updating of the banner text is definitely the right step.
For the 2 visitor UX changes that were generally supported (not auto-expanding NSFW posts and blurring thumbnails), I’m admittedly not familiar with Git myself. Based on the Github discussion of this, would changing both settings at the backend to “false” help to change the default/visitor view? If it’s just changing these two settings, would that constitute a fork that needs long-term maintenance, or could it just be a one-and-done setting change?
If it’s a fork that needs long-term maintenance, I’ll try asking around and see if anyone has the necessary skills to maintain a UI fork with these two changes made. I do think it’s important, it seems to be broadly supported based on the comments in discussions thus far, and the current problem seems to be a lack of capacity rather than will, so if that can be overcome, it may be possible to enact the changes.
NSFW images blurred and no longer auto expand.
The relevant patches need to be applied in lemmy-ui’s source tree (https://github.com/lemmynsfw/lemmy-ui) :
#src/shared/components/post/post-listing.tsx --- post-listing.tsx 2023-12-26 03:43:17.871725423 +0000 +++ post-listing.tsxd 2024-01-04 20:29:53.433999085 +0000 @@ -96,7 +96,7 @@ export class PostListing extends Component<PostListingProps, PostListingState> { state: PostListingState = { showEdit: false, - imageExpanded: true, + imageExpanded: false, viewSource: false, showAdvanced: false, showBody: false,#src/shared/components/common/pictrs-image.tsx --- pictrs-image.tsx 2023-12-26 03:43:17.859724985 +0000 +++ pictrs-image.tsxd 2024-01-04 20:25:41.355154850 +0000 @@ -26,7 +26,7 @@ render() { const { src, icon, iconOverlay, banner, thumbnail, nsfw, pushup, cardTop } = this.props; - let user_blur_nsfw = false; + let user_blur_nsfw = true; if (UserService.Instance.myUserInfo) { user_blur_nsfw = UserService.Instance.myUserInfo?.local_user_view.local_user.blur_nsfw;If at any point this proves to be a headache to maintain, then we’ll have to explore other options.
Better yet, let’s make this more universal. I have no idea what I was thinking using a patch for a codebase that frequently changes.
sed -i 's/imageExpanded: true/imageExpanded: false/g' lemmy-ui/src/shared/components/post/post-listing.tsx sed -i 's/let user_blur_nsfw = false;/let user_blur_nsfw = true;/g' lemmy-ui/src/shared/components/common/pictrs-image.tsxFor some reason I didn’t receive a notification about this reply, but thanks for making the changes!
Hah: I actually wanted the opposite, it annoys me how by default Lemmy blurs all NSFW thumbnails by default. Why the devs can’t make this a simple user preference is beyond me.
That’s been added as a user preference in 0.19.
Oh nice: Thank you for that! Much better now.
Is that disclaimer necessary? It even uses annoying browser alerts and makes everything look broken. I presume people can see it’s NSFW from the description if it’s not obvious otherwise: Having to tell people what to do or not do based on who or where they may be behind their computer screen has gotten so old and weird for the modern day internet. Other than that I’m sorry you went through a rough time and am glad you’re okay, take care and thanks for everything you’ve been offering the internet!
The disclaimer is not necessary, however removing it without touching the code would be fairly difficult due to the way the LemmyNSFW fork is setup. Makes everything super hard to navigate and modify. All the code is minified and otherwise obscured beyond human comprehension. This is why we replace the text as opposed to removing the actual disclaimer altogether.
It’s less work for me. Since all I’m doing is a text replace at the reverse proxy level. I’m not having to change code for this since I’m just replacing what gets sent out. It’d be one thing if this breaks apps, but afaik apps just use the Lemmy API.